feat(lambda): Code.fromDockerBuildAsset #12258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the result of a Docker build as code. The runtime code is expected to be located at `/asset` in the image. Also deprecate `BundlingDockerImage` in favor of `DockerImage`.
|
|
Contributor
Author
eladb
previously requested changes
Dec 29, 2020
eladb
previously requested changes
Feb 17, 2021
eladb
reviewed
Feb 18, 2021
| * `lambda.Code.fromAsset(path)` - specify a directory or a .zip file in the local | ||
| filesystem which will be zipped and uploaded to S3 before deployment. See also | ||
| [bundling asset code](#bundling-asset-code). | ||
| * `lambda.Code.fromDockerBuildAsset(path, options)` - use the result of a Docker |
Contributor
There was a problem hiding this comment.
Let's rename this to fromDockerBuild. I don't see how this can be misinterpreted
eladb
approved these changes
Feb 18, 2021
Contributor
|
Very cool feature |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
@rhboyd worth mentioning in next month's blog |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This was referenced Mar 6, 2021
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the result of a Docker build as code. The runtime code is expected to be
located at
/assetin the image.Also deprecate
BundlingDockerImagein favor ofDockerImage.Closes #11914
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license